Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable24] Check share status when downloading versions #43865

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Feb 27, 2024

Backport of #43859

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from artonge and nfebe February 27, 2024 13:20
@backportbot backportbot bot added 3. to review Waiting for reviews feature: versions javascript php Pull requests that update Php code labels Feb 27, 2024
@artonge artonge changed the title [stable24] [stable25] Check share status when touching versions [stable24] Check share status when touching versions Feb 27, 2024
@artonge artonge marked this pull request as ready for review February 27, 2024 14:29
@artonge artonge added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 27, 2024
@artonge artonge changed the title [stable24] Check share status when touching versions [stable24] Check share status when downloading versions Feb 27, 2024
Signed-off-by: Louis Chemineau <louis@chmn.me>
apps/dav/lib/Server.php Fixed Show fixed Hide fixed
@artonge
Copy link
Contributor

artonge commented Feb 28, 2024

Failing tests are already failing on stable24

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Copy link
Contributor

artonge commented Feb 28, 2024

Cherry-picked 5137757 to avoid yet another PR

@skjnldsv skjnldsv merged commit 6be0289 into stable24 Feb 28, 2024
19 of 28 checks passed
@skjnldsv skjnldsv deleted the backport/43859/stable24 branch February 28, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: versions javascript php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants