-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use viewer to open files still on the simple widget #44076
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was done on purpose, you cannot open viewer on text as text us already using viewer. It will close the text app.
Can you explain the context? :)
The widget is not only rendered in viewer but also in collectives or the folder description where it is used then to open the viewer. I don't quite remember how the behavior was if this is triggered trough text in viewer still, but would say either the close and open or another file is expected or we can safeguard this to only happen if no file is currently open in the viewer. |
It wasn't. The Vue event was missing a stop and therefore the behaviour was unstable and still opening the file as if the link was clicked. I suggest the following, until we support multiple viewer, on top of checking if Viewer supports the mime, please also check if a file is already opened in it. |
97f6404
to
54c8d3e
Compare
Thanks, adjusted |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
54c8d3e
to
7b92e23
Compare
Follow up to #44012
This brings back the behaviour to open the viewer on non-interactive widget rendering.
Fixes recent failures on nextcloud/text#5447 for the link bubble
Checklist