fix: Return only administered groups of a user for subadmins #44141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emoral435
approved these changes
Mar 15, 2024
|
LGMT :) |
This was referenced Mar 18, 2024
Merged
Merged
Merged
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
fix/subadmin-user-groups
branch
from
6c4e4a4
to
3c74e02
Compare
|
Haha, just noticed that my review no longer works ^*^ but LGTM! |
| @@ -137,6 +137,9 @@ protected function getUserData(string $userId, bool $includeScopes = false): ?ar | |||
| $groups = $this->groupManager->getUserGroups($targetUserObject); | |||
| $gids = []; | |||
| foreach ($groups as $group) { | |||
| if (!$this->groupManager->getSubAdmin()->isSubAdminOfGroup($currentLoggedInUser, $group)) { | |||
There was a problem hiding this comment.
Suggested change
| if (!$this->groupManager->getSubAdmin()->isSubAdminOfGroup($currentLoggedInUser, $group)) { | |
| if (!$isAdmin && !$this->groupManager->getSubAdmin()->isSubAdminOfGroup($currentLoggedInUser, $group)) { |
But not sure we should do that.
It might be important to see that a user is in more/other groups?
Merged
skjnldsv
added
stale
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist