fix(dav): Fix quota check for chunk upload #44332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
requested review from
ArtificialOwl and
nfebe
and removed request for
a team
Merged
skjnldsv
approved these changes
Mar 19, 2024
|
/backport to stable28 |
|
/backport to stable27 |
come-nc
force-pushed
the
fix/fix-chunkupload-quota-check
branch
from
176e853
to
d3f2442
Compare
|
/backport to stable29 |
Do not ignore OC-Total-Length when Content-Length and X-Expected-Entity-Length are missing Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/fix-chunkupload-quota-check
branch
from
d3f2442
to
01f59be
Compare
nfebe
approved these changes
Apr 2, 2024
|
The backport to # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b backport/44332/stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 516fb702 01f59be5
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/44332/stable27Error: Failed to push branch backport/44332/stable27: fatal: could not read Username for 'https://github.com': No such device or address Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/44332/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 516fb702 01f59be5
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/44332/stable28Error: Failed to push branch backport/44332/stable28: fatal: could not read Username for 'https://github.com': No such device or address Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable28 |
|
/backport to stable27 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Do not ignore header
OC-Total-LengthwhenContent-LengthandX-Expected-Entity-Lengthare missing.Checklist