Make sass command compatible with macos #44452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
a team,
szaimen and
emoral435
and removed request for
a team
ChristophWurst
approved these changes
Mar 25, 2024
|
Suggested commit title: |
Altahrim
approved these changes
Mar 25, 2024
| "lint": "eslint $(for appdir in $(ls apps); do if ! $(git check-ignore -q $appdir); then echo -n \"$appdir \"; fi; done) core --no-error-on-unmatched-pattern", | ||
| "lint:fix": "eslint $(for appdir in $(ls apps); do if ! $(git check-ignore -q $appdir); then echo -n \"$appdir \"; fi; done) core --no-error-on-unmatched-pattern --fix", | ||
| "lint": "eslint $(for appdir in $(ls apps); do if ! $(git check-ignore -q $appdir); then printf \"$appdir \"; fi; done) core --no-error-on-unmatched-pattern", | ||
| "lint:fix": "eslint $(for appdir in $(ls apps); do if ! $(git check-ignore -q $appdir); then printf \"$appdir \"; fi; done) core --no-error-on-unmatched-pattern --fix", |
There was a problem hiding this comment.
I am not sure the -n if even necessary:
Suggested change
| "lint:fix": "eslint $(for appdir in $(ls apps); do if ! $(git check-ignore -q $appdir); then printf \"$appdir \"; fi; done) core --no-error-on-unmatched-pattern --fix", | |
| "lint:fix": "eslint $(for appdir in $(ls apps); do if ! $(git check-ignore -q $appdir); then echo $appdir; fi; done) core --no-error-on-unmatched-pattern --fix", |
Signed-off-by: Marco <marcoambrosini@icloud.com>
marcoambrosini
force-pushed
the
make-sass-command-compatible-with-macos
branch
from
80a56e3
to
34fb38b
Compare
emoral435
approved these changes
Mar 25, 2024
|
/compile amend/ |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
make-sass-command-compatible-with-macos
branch
from
1d92060
to
e8da4a3
Compare
delete-merged-branch
bot
deleted the
make-sass-command-compatible-with-macos
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
printfinstead ofecho -n