Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(share): Send correct share attributes upon share creation #44484

Merged
merged 2 commits into from
Mar 26, 2024
Merged

fix(share): Send correct share attributes upon share creation #44484

merged 2 commits into from
Mar 26, 2024

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented Mar 26, 2024 •
edited
Loading

  • Send correct share attributes (share.attributes) to server upon creation.
  • Delete parts of code that create or reference, share.hasDownloadPermission (Not required by Share API)

Resolves : #44131

Before After
Screenshot from 2024-03-26 13-58-24 Screenshot from 2024-03-26 13-58-00

@nfebe nfebe self-assigned this Mar 26, 2024
susnux
susnux approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@nfebe
Copy link
Contributor Author

nfebe commented Mar 26, 2024

/backport to stable28

@nfebe
Copy link
Contributor Author

nfebe commented Mar 26, 2024

/backport to stable27

@nfebe nfebe force-pushed the 44131-persist-initial-share-configs branch from b39487f to 27205b0 Compare March 26, 2024 13:10
emoral435
emoral435 approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nfebe
Copy link
Contributor Author

nfebe commented Mar 26, 2024

/compile /

@nfebe
fix(share): Send correct share attributes upon share creation
3a5475b 
- Send correct share attributes (`share.attributes`) to server upon creation.
- Delete parts of code that create or reference, `share.hasDownloadPermission`
(Not required by Share API)

Resolves : #44131

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nfebe nfebe force-pushed the 44131-persist-initial-share-configs branch from 429bdb7 to 3a5475b Compare March 26, 2024 15:39
@nfebe
Copy link
Contributor Author

nfebe commented Mar 26, 2024

/compile /

@nextcloud-command
chore(assets): Recompile assets
d5b6578 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nfebe nfebe merged commit 7eb31de into master Mar 26, 2024
104 checks passed
@nfebe nfebe deleted the 44131-persist-initial-share-configs branch March 26, 2024 23:56
This was referenced Mar 26, 2024
Merged
Merged
@Altahrim Altahrim removed the 3. to review Waiting for reviews label Mar 27, 2024
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
Merged
81 tasks
@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emoral435 emoral435 emoral435 approved these changes

@Altahrim Altahrim Altahrim approved these changes

@susnux susnux susnux approved these changes

@artonge artonge Awaiting requested review from artonge

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@nfebe nfebe

Labels
27-feedback 28-feedback 29-feedback feature: sharing feedback-requested
Projects
📁 Files team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Share settings not persisted on new shares
5 participants
@nfebe @susnux @Altahrim @emoral435 @nextcloud-command