Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): Fix translation of "Delete file" #44526

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Mar 28, 2024

Summary

Plurals should only be used with the %n placeholder

Checklist

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 30 milestone Mar 28, 2024
@nickvergessen nickvergessen self-assigned this Mar 28, 2024
@nickvergessen nickvergessen changed the title Bugfix/43947/delete file not translated fix(files): Fix translation of "Delete file" Mar 28, 2024
@nickvergessen
Copy link
Member Author

/backport 1dd6f25 to stable29

@nickvergessen
Copy link
Member Author

/backport 1dd6f25 to stable28

@nickvergessen
Copy link
Member Author

/backport 1dd6f25 to stable27

@skjnldsv skjnldsv merged commit e317ebd into master Mar 28, 2024
104 checks passed
@skjnldsv skjnldsv deleted the bugfix/43947/delete-file-not-translated branch March 28, 2024 14:28
Copy link

backportbot bot commented Mar 28, 2024

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b backport/44526/stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 1dd6f250

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/44526/stable27

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Mar 28, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/44526/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 1dd6f250

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/44526/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: "Delete file" and "Delete folder" context menu items not localised on v27.1.7
3 participants