Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP enh(encryption): Adjust messaging/etc #44601

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Apr 1, 2024

Fixes #44532
Helps with #43123

Also adds a warning so that people aren't confused when the "Enable server-side encryption" toggle can't be toggled anymore after encryption is enabled.

Fix split out into separate PR while I mess with this other stuff: #44604

  • Resolves: #

Summary

TODO

  • Add warning that once enabled, encryption cannot be disabled from the web UI (and that's why radio button stays grayed out even once when enabled)
  • Add tip/notice about why "Enable server-side encryption" can't be toggled in (because the default encryption module app isn't enabled!)
  • Warn if E2E app is active (incompatible with each other currently)

Checklist

Fixes #44532 
Helps with #43123 

Also adds a warning so that people aren't confused when the "Enable server-side encryption" toggle can't be toggled anymore after encryption is enabled.

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards
Copy link
Member Author

/compile /

nextcloud-command and others added 2 commits April 1, 2024 21:36
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards
Copy link
Member Author

/compile /

nextcloud-command and others added 2 commits April 1, 2024 22:01
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards
Copy link
Member Author

/compile /

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@joshtrichards joshtrichards changed the title fix(encryption): Clicking on default module sets bogus value WIP enh(encryption): Adjust messaging/etc Apr 1, 2024
@susnux susnux added this to the Nextcloud 30 milestone Apr 18, 2024
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@skjnldsv skjnldsv added the 2. developing Work in progress label Jul 27, 2024
@skjnldsv skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Default encryption module not loaded (v2.16.0)
4 participants