Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix(files_sharing): Disable autocomplete for share label and password #44617

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Apr 2, 2024

Backport of #44575

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added this to the Nextcloud 29 milestone Apr 2, 2024
Prevent browsers - as good as possible - from filling in user credentials as share label and password.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
Copy link
Contributor

susnux commented Apr 2, 2024

/compile

@susnux susnux marked this pull request as ready for review April 2, 2024 12:12
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 2, 2024
@susnux
Copy link
Contributor

susnux commented Apr 3, 2024

@sorbaugh @skjnldsv can we have this in next 29 RC to prevent regressions between 28 an 29?

@blizzz blizzz mentioned this pull request Apr 4, 2024
67 tasks
@blizzz blizzz merged commit 2ddac31 into stable29 Apr 4, 2024
103 of 104 checks passed
@blizzz blizzz deleted the backport/44575/stable29 branch April 4, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: sharing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants