Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appconfig): format app values #44644

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Conversation

ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented Apr 4, 2024

returns formated values based on type when calling getAllValues() and searchValues()

note: deprecated method getValues() use getAllValues() but if the config value is defined as MIXED (default), the value is kept as a string.

original:

{
    "key1": "value1",
    "key2": "value0",
    "key6": "1",
    "key7": "{\"test1\":1,\"test2\":2}",
    "test8": "1",
    "key3": "value0",
    "key4": "3",
    "key5": "3.14"
}

new:

{
    "key1": "value1",
    "key2": "value0",
    "key6": true,
    "key7": {
        "test1": 1,
        "test2": 2
    },
    "test8": true,
    "key3": "value0",
    "key4": 3,
    "key5": 3.14
}

same as #43258 with tests

@ArtificialOwl ArtificialOwl added the 3. to review Waiting for reviews label Apr 4, 2024
@ArtificialOwl ArtificialOwl added this to the Nextcloud 29 milestone Apr 4, 2024
@ArtificialOwl ArtificialOwl requested review from skjnldsv, a team, Fenn-CS and sorbaugh and removed request for a team April 4, 2024 01:33
@ArtificialOwl
Copy link
Member Author

/backport to stable29

lib/private/AppConfig.php Outdated Show resolved Hide resolved
lib/private/AppConfig.php Outdated Show resolved Hide resolved
@blizzz blizzz mentioned this pull request Apr 4, 2024
67 tasks
@ArtificialOwl ArtificialOwl force-pushed the enh/noid/returns-formated-app-values branch 3 times, most recently from cffdaed to 40d7716 Compare April 4, 2024 18:45
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl ArtificialOwl force-pushed the enh/noid/returns-formated-app-values branch from 40d7716 to 97e59b1 Compare April 5, 2024 18:49
@blizzz blizzz mentioned this pull request Apr 8, 2024
67 tasks
@blizzz blizzz modified the milestones: Nextcloud 29, Nextcloud 30 Apr 8, 2024
@susnux susnux merged commit 3aa9c53 into master Apr 17, 2024
168 checks passed
@susnux susnux deleted the enh/noid/returns-formated-app-values branch April 17, 2024 15:11
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants