Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DateTimeFormatter): Adjust invalid doc blocks #44663

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Apr 4, 2024

Summary

Noticed this in the psalm baseline, we can fix this easily so 🧹

Checklist

@susnux susnux requested review from a team, ArtificialOwl, Fenn-CS, sorbaugh and yemkareems and removed request for a team and sorbaugh April 4, 2024 21:33
@susnux susnux added 3. to review Waiting for reviews php Pull requests that update Php code labels Apr 4, 2024
@susnux susnux added this to the Nextcloud 30 milestone Apr 4, 2024
@susnux susnux requested a review from a team April 5, 2024 10:59
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with nitpick

lib/private/DateTimeFormatter.php Outdated Show resolved Hide resolved
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@skjnldsv skjnldsv enabled auto-merge April 5, 2024 11:54
@skjnldsv skjnldsv merged commit a63f9f2 into master Apr 5, 2024
167 checks passed
@skjnldsv skjnldsv deleted the fix/invalid-doc-block branch April 5, 2024 12:47
@come-nc come-nc mentioned this pull request Apr 8, 2024
4 tasks
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feedback-requested php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants