Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dav): Rate limit address book creation #44664

Merged
merged 1 commit into from
May 28, 2024
Merged

fix(dav): Rate limit address book creation #44664

merged 1 commit into from
May 28, 2024

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Apr 4, 2024 •
edited
Loading

  • Resolves: #

Summary

TODO

  • ...

Checklist

@susnux susnux added this to the Nextcloud 30 milestone Apr 18, 2024
@hamza221 hamza221 force-pushed the fix/dav/rate-limit-create-adress-book branch 2 times, most recently from 503bf38 to c111afe Compare May 8, 2024 18:06
@hamza221 hamza221 added bug 3. to review Waiting for reviews feature: dav feature: carddav Related to CardDAV internals labels May 8, 2024
@hamza221 hamza221 marked this pull request as ready for review May 8, 2024 18:08
@hamza221
fix(dav): Rate limit address book creation
fe78094 
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
@hamza221 hamza221 force-pushed the fix/dav/rate-limit-create-adress-book branch from c111afe to fe78094 Compare May 27, 2024 12:55
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 28, 2024
@hamza221
Copy link
Contributor Author

/backport! to stable28

@hamza221
Copy link
Contributor Author

/backport! to stable29

@hamza221
Copy link
Contributor Author

/backport! to stable27

@hamza221
Copy link
Contributor Author

/backport! to stable26

@backportbot backportbot bot mentioned this pull request May 28, 2024
Merged
2 tasks
This was referenced May 28, 2024
Merged
Merged
Merged
@hamza221 hamza221 merged commit 236c949 into master May 28, 2024
156 checks passed
@hamza221 hamza221 deleted the fix/dav/rate-limit-create-adress-book branch May 28, 2024 14:46
@kesselb
Copy link
Contributor

kesselb commented Jun 7, 2024

/backport to stable29

@backportbot backportbot
Copy link

backportbot bot commented Jun 7, 2024

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/44664/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick fe780945

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/44664/stable29

Error: No changes found in backport branch

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@kesselb
Copy link
Contributor

kesselb commented Jun 7, 2024

My bad, overlooked the existing 29 backport 🙈

@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
@joshtrichards joshtrichards mentioned this pull request Sep 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miaulalala miaulalala miaulalala left review comments

@kesselb kesselb kesselb approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@tcitworld tcitworld Awaiting requested review from tcitworld

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: carddav Related to CardDAV internals feature: dav
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
5 participants
@hamza221 @kesselb @ChristophWurst @miaulalala @susnux