Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(oc-dialog): Get rid of the overlay #44717

Merged
merged 2 commits into from
Apr 8, 2024
Merged

fix(oc-dialog): Get rid of the overlay #44717

merged 2 commits into from
Apr 8, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Apr 8, 2024 •
edited by artonge
Loading

Summary

  • Increment Z-index of oc-dialog-dim
  • Increment z-index of oc-dialog
  • Insert oc-dialog-dim before oc-dialog

Screencast

bug-report

2024-03-26 14-35-52

After:

Nextcloud-Fix

Checklist

@susnux susnux added bug 3. to review Waiting for reviews labels Apr 8, 2024
@susnux susnux added this to the Nextcloud 30 milestone Apr 8, 2024
@susnux susnux requested review from a team, szaimen, sorbaugh and emoral435 and removed request for a team April 8, 2024 11:33
@jadjoud @susnux
fix(oc-dialog): Get rid of the overlay
8e136c3 
- Icrement Z-index of oc-dialog-dim
- Increment z-index of oc-dialog- Insert oc-dialog-dim before oc-dialog

Co-authored-by: Co-author RayanBekri <rmt.bekri@gmail.com>"
Signed-off-by: JEEEEEEEEEEEEEEEEEEEEEED <118366366+jadjoud@users.noreply.github.com>
@susnux
Copy link
Contributor Author

susnux commented Apr 8, 2024

/backport to stable29

@susnux susnux requested review from artonge and removed request for sorbaugh April 8, 2024 11:38
emoral435
emoral435 approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but is this issue not a good contender to replace with NcDialog?

@emoral435
Copy link
Contributor

emoral435 commented Apr 8, 2024 •
edited
Loading

From what I see, this functionality can be all wrapped into a custom button generated by NcDialog -> https://github.com/nextcloud/server/blob/ff2100a4e515988d3ba44c7cfe734d19a6b4b377/apps/settings/src/components/Users/UserRow.vue#L538C7-L545C10 , but again, this still works :)

@susnux
Copy link
Contributor Author

susnux commented Apr 8, 2024

/compile

@susnux susnux enabled auto-merge April 8, 2024 13:00
@nextcloud-command
chore(assets): Recompile assets
cfaaff1 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux merged commit f8de545 into master Apr 8, 2024
104 checks passed
@susnux susnux deleted the fix/oc-dialog-overlay branch April 8, 2024 14:01
@backportbot backportbot bot mentioned this pull request Apr 8, 2024
Merged
2 tasks
@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emoral435 emoral435 emoral435 approved these changes

@artonge artonge artonge approved these changes

@szaimen szaimen Awaiting requested review from szaimen szaimen was automatically assigned from nextcloud/server-frontend

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feedback-requested
Projects
None yet
Milestone
Nextcloud 30
5 participants
@susnux @emoral435 @artonge @jadjoud @nextcloud-command