fix(memcache): remove double $$ to fix error

[Velwark]

Extra Dollar Sign caused errors in Nextcloud. Removing the Dollar Sign Solved the Problem.

• Resolves: #

Summary

TODO

• ...

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[solracsf]

/backport to stable29

[solracsf]

/backport to stable28

[solracsf]

/backport to stable27

[come-nc]

Nice catch.
This made search for $$ in our codebase, I think

server/lib/private/DB/QueryBuilder/QueryBuilder.php

Line 980 in fea0278

$$groupBys = $groupBys[0];

is also a typo, no?

[Velwark]

Nice catch. This made search for $$ in our codebase, I think

server/lib/private/DB/QueryBuilder/QueryBuilder.php

Line 980 in fea0278

$$groupBys = $groupBys[0];

is also a typo, no?

I‘m really no PHP expert myself. The Double Dollar Sign is a Variable Variable in PHP. As Long as ist doesn‘t throw any erros that could just be right.

The Double Dollar sign here in the Commit caused lots of errors on my Instance.

By the way, how do i merge this commit?

[come-nc]

Nice catch. This made search for $$ in our codebase, I think

server/lib/private/DB/QueryBuilder/QueryBuilder.php

Line 980 in fea0278

$$groupBys = $groupBys[0];

is also a typo, no?

I‘m really no PHP expert myself. The Double Dollar Sign is a Variable Variable in PHP. As Long as ist doesn‘t throw any erros that could just be right.

I think $groupBys is an array there, so it makes no sense. I’ll try to find time to debug&fix.

The Double Dollar sign here in the Commit caused lots of errors on my Instance.

Note that I think that means you have profiling enabled, you should disable it outside of dev instances. Check with occ config:system:get profiler.

By the way, how do i merge this commit?

You do not, we need to wait for someone with the power to do so to force merge, because the CI cannot pass on PRs coming from forks.

[welcome]

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

[AndyScherzinger]

Thanks for your contribution @Velwark 🎉

Highly appreciated 💯🙏🎉

[nickvergessen]

Looking at

server/lib/private/DB/QueryBuilder/QueryBuilder.php

Line 952 in fea0278

$groupBys = $groupBys[0];

it seems to be a bug in line 980

[come-nc]

Looking at

server/lib/private/DB/QueryBuilder/QueryBuilder.php

Line 952 in fea0278

$groupBys = $groupBys[0];

it seems to be a bug in line 980

fixed it in 6953d1f in the psalm bump PR which I intend to get merged at some point.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

[joshtrichards]

The Double Dollar sign here in the Commit caused lots of errors on my Instance.

@Velwark What were the errors you were seeing/under what conditions? Asking since this PR wasn't connected to prior bug report and just to get it on record for searches/etc. Thanks!

[nickvergessen]

Well it triggered a warning depending on PHP config because of the use of Undefined variable $300 etc.

[joshtrichards]

👍 I just realized this is in the wrapper (so only when redis_log_file is configured).

Probably a less traveled code path. Explains why there weren't a bunch of related bug reports.