fix(capabilities): Expose if mod-rewrite is working via capabilities #44799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable29 |
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
bugfix/44798/expose-mod-rewrite
branch
from
083140a
to
bbaaaf4
Compare
provokateurin
approved these changes
Apr 12, 2024
ShGKme
reviewed
Apr 12, 2024
| @@ -59,6 +60,7 @@ public function getCapabilities(): array { | |||
| 'webdav-root' => $this->config->getSystemValueString('webdav-root', 'remote.php/webdav'), | |||
| 'reference-api' => true, | |||
| 'reference-regex' => IURLGenerator::URL_REGEX_NO_MODIFIERS, | |||
| 'mod-rewrite-working' => $this->config->getSystemValueBool('htaccess.IgnoreFrontController') || getenv('front_controller_active') === 'true', | |||
There was a problem hiding this comment.
Looks like a copy-paste of
Can we then use capabilities there to define modRewriteWorking in JSConfig?
This was referenced Apr 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modRewriteWorkingvia capabilities to allow pretty URL by clients #44798Currently only exposed on JS initial state for the webfrontend, not allowing clients to rely on it.
Checklist