Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(files): Switch widget icon to primary color #44806

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Apr 13, 2024

Summary

  • Switch widget to primary color
    image

Checklist

@Pytal Pytal added design Design, UI, UX, etc. 3. to review Waiting for reviews labels Apr 13, 2024
@Pytal Pytal added this to the Nextcloud 30 milestone Apr 13, 2024
@Pytal Pytal self-assigned this Apr 13, 2024
@Pytal Pytal requested a review from skjnldsv as a code owner April 13, 2024 00:42
@Pytal
Copy link
Member Author

Pytal commented Apr 13, 2024

/backport to stable29

@Pytal Pytal enabled auto-merge April 13, 2024 00:43
@Pytal Pytal changed the title chore(files): Switch widget to primary color chore(files): Switch widget icon to primary color Apr 13, 2024
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folder icons should indeed be primary color, but text documents not. :) If it’s a .doc/.odt, it has a distinct blue color, not primary (and this seems to be plain text, right?) @Pytal the correct coloring is in #44340 (comment)

Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the chore/widget-primary-color branch from 2d0664d to d532cb0 Compare April 15, 2024 17:59
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants