Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid douple expireDate parsing #44838

Merged
merged 2 commits into from
Apr 18, 2024
Merged

fix: avoid douple expireDate parsing #44838

merged 2 commits into from
Apr 18, 2024

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented Apr 15, 2024

Resolves : #41229

@nfebe nfebe self-assigned this Apr 15, 2024
@nfebe nfebe force-pushed the 41229-expire-date-fed-share branch from 9241d0b to 7c0832e Compare April 15, 2024 20:11
@nfebe nfebe force-pushed the 41229-expire-date-fed-share branch from 7c0832e to 68753c9 Compare April 15, 2024 20:39
@nfebe nfebe requested review from artonge, come-nc and Altahrim and removed request for artonge and come-nc April 15, 2024 20:42
@nfebe nfebe marked this pull request as ready for review April 15, 2024 20:43
@nfebe nfebe added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 15, 2024
@nfebe nfebe force-pushed the 41229-expire-date-fed-share branch from 68753c9 to 63d5f75 Compare April 15, 2024 21:23
@nfebe nfebe changed the title refactor(shareApiController): use contrusctor property promotion & DI… refactor(shareApiController): avoid douple expireDate parsing Apr 15, 2024
@nfebe nfebe force-pushed the 41229-expire-date-fed-share branch from 63d5f75 to 634df14 Compare April 15, 2024 21:39
@nfebe nfebe changed the title refactor(shareApiController): avoid douple expireDate parsing fix: avoid douple expireDate parsing Apr 15, 2024
@nfebe nfebe force-pushed the 41229-expire-date-fed-share branch 3 times, most recently from b5b79cc to ff88095 Compare April 16, 2024 17:15
@nfebe
Copy link
Contributor Author

nfebe commented Apr 17, 2024

Test failures related and looking.

@nfebe nfebe force-pushed the 41229-expire-date-fed-share branch 2 times, most recently from 56e56d8 to 1c28f7a Compare April 18, 2024 00:29
@nfebe
refactor(shareApiController): use contrusctor property promotion & DI…
9a0913a 
… logger

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nfebe
fix(shareApiController): avoid duplicated expiryDate operations
ec8a0a6 
`expireDate` can be set once and used anywhere needed, the current implementation,
duplicates this behavior which leads to `parseDate` receiving an a date object it
parsed and returend earlier in the createShare method.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nfebe nfebe force-pushed the 41229-expire-date-fed-share branch from 1c28f7a to ec8a0a6 Compare April 18, 2024 01:01
@nfebe nfebe merged commit 4cbe826 into master Apr 18, 2024
157 checks passed
@nfebe nfebe deleted the 41229-expire-date-fed-share branch April 18, 2024 01:26
@nfebe
Copy link
Contributor Author

nfebe commented Apr 18, 2024

/backport to stable29

@nfebe
Copy link
Contributor Author

nfebe commented Apr 18, 2024

/backport to stable28

@nfebe
Copy link
Contributor Author

nfebe commented Apr 18, 2024

/backport to stable27

@backportbot backportbot bot mentioned this pull request Apr 18, 2024
Merged
This was referenced Apr 18, 2024
Closed
Merged
@nickvergessen
Copy link
Member

This actually breaks Talk attachment:
https://github.com/nextcloud/spreed/actions/runs/8736657894/job/23972035833?pr=12147

@nickvergessen nickvergessen mentioned this pull request Apr 18, 2024
Merged
4 tasks
@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

This was referenced Jun 10, 2024
Merged
Merged
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@Altahrim Altahrim Altahrim approved these changes

@come-nc come-nc Awaiting requested review from come-nc

Assignees

@nfebe nfebe

Labels
3. to review Waiting for reviews feature: sharing feedback-requested
Projects
📁 Files team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Federation Share with Expiration Date, ($expireDate) must be of type string, DateTime given
4 participants
@nfebe @nickvergessen @Altahrim @artonge