Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sharingDetails): Show correct share target #44839

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

Fenn-CS
Copy link
Contributor

@Fenn-CS Fenn-CS commented Apr 15, 2024

The share details page should show the target email or user/server to which
the user is creating the share.

Before email Before federation After email After federation
before-email before-federation after-email after-federation

@Fenn-CS Fenn-CS added 3. to review Waiting for reviews feature: sharing labels Apr 15, 2024
@Fenn-CS Fenn-CS self-assigned this Apr 15, 2024
@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Apr 15, 2024

/backport to stable29

@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Apr 15, 2024

/backport to stable28

@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Apr 15, 2024

/backport to stable27

@kesselb
Copy link
Contributor

kesselb commented Apr 16, 2024

Please use the right type for your commit message. Refactoring is changing code without changing behavior.

@Fenn-CS Fenn-CS requested a review from susnux April 16, 2024 16:54
@Fenn-CS Fenn-CS changed the title refactor(sharingDetails): Show correct share target fix(sharingDetails): Show correct share target Apr 16, 2024
@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Apr 16, 2024

/compile

The share details page should show the target email or user/server to which
the user is creating the share.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@Fenn-CS Fenn-CS requested a review from susnux April 18, 2024 10:12
@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Apr 18, 2024

/compile

@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Apr 18, 2024

/backport to stable29

@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Apr 18, 2024

/backport to stable28

@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Apr 18, 2024

/backport to stable27

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux added this to the Nextcloud 30 milestone Apr 18, 2024
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@susnux susnux merged commit a540f54 into master Apr 18, 2024
104 checks passed
@susnux susnux deleted the improve-share-with-details branch April 18, 2024 13:01
Copy link

backportbot bot commented Apr 18, 2024

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b backport/44839/stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8ec15c44 3a5ff0f6

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/44839/stable27

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Apr 18, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/44839/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8ec15c44 3a5ff0f6

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/44839/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Apr 18, 2024

/backport to stable28

@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Apr 18, 2024

/backport to stable27

Copy link

backportbot bot commented Apr 18, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/44839/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8ec15c44 3a5ff0f6

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/44839/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Apr 18, 2024

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b backport/44839/stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8ec15c44 3a5ff0f6

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/44839/stable27

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants