Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/occ clear avatar cache command #44840

Merged
merged 4 commits into from
Apr 16, 2024
Merged

Feature/occ clear avatar cache command #44840

merged 4 commits into from
Apr 16, 2024

Conversation

yemkareems
Copy link
Contributor

Summary

TODO

  • ...

Checklist

@yemkareems
feat: command added to clear avatar cache manually
703214f 
Signed-off-by: yemkareems <yemkareems@gmail.com>
@yemkareems
feat: license wordings, minor php warnings corrected
5201056 
Signed-off-by: yemkareems <yemkareems@gmail.com>
szaimen
szaimen approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this yesterday and it worked :)

@yemkareems
feat: wordings corrected as suggested
04b112c 
Signed-off-by: yemkareems <yemkareems@gmail.com>
@yemkareems
feat: changes by build/autoloaderchecker.sh
1d50d78 
Signed-off-by: yemkareems <yemkareems@gmail.com>
@yemkareems yemkareems merged commit 29f0448 into master Apr 16, 2024
157 checks passed
@yemkareems yemkareems deleted the feature/occ-clear-avatar-cache-command branch April 16, 2024 09:43
@welcome Welcome
Copy link

welcome bot commented Apr 16, 2024

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

come-nc
come-nc reviewed Apr 16, 2024
View reviewed changes
core/Command/User/ClearGeneratedAvatarCacheCommand.php
Comment on lines +1 to +2
<?php
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing strict_types, always add it to new files.
We should add that to coding standard quite frankly, with existing files in the baseline, it would make sense.

@come-nc come-nc added 4. to release Ready to be released and/or waiting for tests to finish feature: occ pending documentation This pull request needs an associated documentation update labels Apr 16, 2024
@come-nc come-nc added this to the Nextcloud 30 milestone Apr 16, 2024
@yemkareems yemkareems restored the feature/occ-clear-avatar-cache-command branch April 17, 2024 03:59
nickvergessen
nickvergessen reviewed Apr 17, 2024
View reviewed changes
lib/composer/composer/autoload_classmap.php
@@ -1134,6 +1134,7 @@
'OC\\Core\\Command\\User\\AuthTokens\\Add' => $baseDir . '/core/Command/User/AuthTokens/Add.php',
'OC\\Core\\Command\\User\\AuthTokens\\Delete' => $baseDir . '/core/Command/User/AuthTokens/Delete.php',
'OC\\Core\\Command\\User\\AuthTokens\\ListCommand' => $baseDir . '/core/Command/User/AuthTokens/ListCommand.php',
'OC\\Core\\Command\\User\\ClearGeneratedAvatarCacheCommand' => $baseDir . '/core/Command/User/ClearGeneratedAvatarCacheCommand.php',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lib/composer/composer/autoload_static.php is missing a similar line. My PR in https://github.com/nextcloud/server/pull/44886/files#diff-590bf0226c83824761fbf7bc57bf2b9a154c9303a649ad0c2b12ee558787a410 is listing this now...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickvergessen Sure ll have a look at this and raise a PR to fix the same. Thank you

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already did in #44888 this time

@nickvergessen nickvergessen mentioned this pull request Apr 17, 2024
Merged
4 tasks
@szaimen szaimen deleted the feature/occ-clear-avatar-cache-command branch April 18, 2024 06:35
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 1, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@come-nc come-nc come-nc left review comments

@artonge artonge artonge approved these changes

@szaimen szaimen szaimen approved these changes

Assignees

@yemkareems yemkareems

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: occ feedback-requested pending documentation This pull request needs an associated documentation update
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
5 participants
@yemkareems @nickvergessen @artonge @szaimen @come-nc