Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(comments): Fix issues thrown by comments sidebar tab code #44868

Merged
merged 2 commits into from
Apr 17, 2024
Merged

fix(comments): Fix issues thrown by comments sidebar tab code #44868

merged 2 commits into from
Apr 17, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Apr 16, 2024 •
edited
Loading

  • Resolves: #

Summary

When the comments tab is used instead of the merged activity+comments, then some issues are throws due to prop manipulation and duplicated names (resourceId as prop and data).

This is fixed as well as some other vue related errors in the sidebar

Checklist

@susnux susnux added bug 3. to review Waiting for reviews labels Apr 16, 2024
@susnux susnux added this to the Nextcloud 30 milestone Apr 16, 2024
@susnux susnux requested a review from skjnldsv as a code owner April 16, 2024 22:19
@susnux
Copy link
Contributor Author

susnux commented Apr 16, 2024

/backport to stable29

@susnux
Copy link
Contributor Author

susnux commented Apr 16, 2024

/backport to stable28

@susnux susnux requested a review from artonge April 17, 2024 10:52
Pytal
Pytal approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@susnux
fix(comments): Fix issues thrown by comments sidebar tab code
6c9ca8b 
When the comments tab is used instead of the merged activity+comments, then some issues are throws due to prop altering and duplicated names (resourceId as prop and data).

This is fixed as well as some other vue related errors in the sidebar

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: Compile assets
fd7906d 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux enabled auto-merge April 17, 2024 18:11
@susnux susnux merged commit 863b091 into master Apr 17, 2024
104 checks passed
@susnux susnux deleted the fix/sidebar-comments branch April 17, 2024 18:46
This was referenced Apr 17, 2024
Merged
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 1, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
@solracsf solracsf mentioned this pull request Jul 29, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@Pytal Pytal Pytal approved these changes

@emoral435 emoral435 Awaiting requested review from emoral435

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: comments feedback-requested
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
4 participants
@susnux @artonge @Pytal @joshtrichards