Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): Clear search filter when changing directory or view #44882

Merged
merged 2 commits into from
Apr 17, 2024
Merged

fix(files): Clear search filter when changing directory or view #44882

merged 2 commits into from
Apr 17, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Apr 17, 2024

Summary

When using the unified search to filter in the current view, the filter should be reset when the user changes the view or directory.

Checklist

@susnux
fix(files): Ensure search query is cleared when changing view or dire…
16eebd3 
…ctory

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: Compile assets
4ae2642 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added this to the Nextcloud 30 milestone Apr 17, 2024
@susnux susnux requested a review from skjnldsv as a code owner April 17, 2024 12:12
@susnux
Copy link
Contributor Author

susnux commented Apr 17, 2024

/backport to stable29

@susnux
Copy link
Contributor Author

susnux commented Apr 17, 2024

/backport! to stable28

@backportbot backportbot bot mentioned this pull request Apr 17, 2024
Merged
2 tasks
nfebe
nfebe approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@nfebe nfebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@susnux susnux enabled auto-merge April 17, 2024 13:09
@susnux susnux merged commit f865f44 into master Apr 17, 2024
104 checks passed
@susnux susnux deleted the fix/files-search-clearing branch April 17, 2024 14:13
@backportbot backportbot bot mentioned this pull request Apr 17, 2024
Merged
2 tasks
@susnux susnux mentioned this pull request May 17, 2024
Closed
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfebe nfebe nfebe approved these changes

@artonge artonge artonge approved these changes

@Pytal Pytal Awaiting requested review from Pytal

@emoral435 emoral435 Awaiting requested review from emoral435

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: files regression
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
3 participants
@susnux @artonge @nfebe