fix(caldav): When message is a reply compare the message sender not the recipient #44893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianKrupinski
requested review from
ChristophWurst,
miaulalala and
tcitworld
as code owners
solracsf
changed the title
Comment on lines
575
to
576
| } | ||
| elseif (strcasecmp($attendee->getValue(), $iTipMessage->recipient) === 0) { |
There was a problem hiding this comment.
Suggested change
| } | |
| elseif (strcasecmp($attendee->getValue(), $iTipMessage->recipient) === 0) { | |
| } elseif (strcasecmp($attendee->getValue(), $iTipMessage->recipient) === 0) { |
|
/backport to stable29 |
|
/backport to stable28 |
I'm sorry, I mixed up the classes. We want to unit test Move the tests please |
|
/backport to stable27 |
kesselb
approved these changes
Jun 25, 2024
…he recipient Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com> Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
SebastianKrupinski
force-pushed
the
fix/issue-43115
branch
from
96d9b4e
to
d7eb509
Compare
miaulalala
approved these changes
Jun 26, 2024
This was referenced Jun 26, 2024
Merged
Merged
This was referenced Jul 1, 2024
9 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When message is a reply compare the message sender not the recipient.