Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): Retry deleting a file if currently locked #44901

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Apr 17, 2024

Resolves: #44631

Summary

If a file is currently locked, wait and retry the delete operation.
Also add a user message so to inform the user.

Checklist

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added this to the Nextcloud 30 milestone Apr 17, 2024
@susnux susnux requested review from Pytal and a team April 17, 2024 18:08
@susnux susnux requested a review from skjnldsv as a code owner April 17, 2024 18:08
@susnux susnux requested review from Fenn-CS and szaimen and removed request for a team April 17, 2024 18:08
@susnux
Copy link
Contributor Author

susnux commented Apr 17, 2024

/backport to stable29

Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would mean that a deletion would be retried infinitely until page reload in the case that the file never unlocks? Seems strange and would be better to just tell the user to retry in 10s or contact sysadmin no?

@skjnldsv skjnldsv added 2. developing Work in progress stale Ticket or PR with no recent activity and removed 3. to review Waiting for reviews labels Jul 27, 2024
This was referenced Jul 30, 2024
This was referenced Aug 5, 2024
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
@skjnldsv skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress backport-request bug feature: files stale Ticket or PR with no recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: delete action failed - cannot delete or move a file
3 participants