Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(settings): Save one HTTP request on enabling an app #44939

Merged
merged 2 commits into from
May 6, 2024
Merged

fix(settings): Save one HTTP request on enabling an app #44939

merged 2 commits into from
May 6, 2024
+8 −8

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Apr 19, 2024

Summary

This prevents one HTTP request for most situations (301 from apps/files to apps/files/) and helps users with faulty reverse-proxy configuration.

Checklist

@susnux susnux added bug 3. to review Waiting for reviews labels Apr 19, 2024
@susnux susnux added this to the Nextcloud 30 milestone Apr 19, 2024
@susnux susnux requested review from a team, szaimen, sorbaugh and emoral435 and removed request for a team April 19, 2024 20:04
@susnux susnux changed the title fix(settings): Prevent one HTTP request on enabling an app fix(settings): Save one HTTP request on enabling an app Apr 19, 2024
@susnux
Copy link
Contributor Author

susnux commented Apr 19, 2024

/backport to stable29

@susnux
Copy link
Contributor Author

susnux commented Apr 19, 2024

/backport to stable28

szaimen
szaimen approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly sure how this helps but fine by me

@susnux
Copy link
Contributor Author

susnux commented Apr 19, 2024

Not exactly sure how this helps but fine by me

We prevent the 301 HTTP response for apps/files -> apps/files/ and directly use the trailing slash.
This is just one HTTP request (due to redirect), but this prevents invalid redirects by webservers (see linked issue).

This was referenced Apr 21, 2024
Closed
Closed
@litinoveweedle litinoveweedle mentioned this pull request Apr 26, 2024
Closed
8 tasks
susnux added 2 commits May 6, 2024 16:12
@susnux
fix(settings): When testing server stability, request URL with traili…
b156bcd 
…ng slash

This prevents one HTTP request for most situations (301 from `apps/files` to `apps/files/`)
and helps users with faulty reverse-proxy configuration.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: Compile assets
c81887c 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux enabled auto-merge May 6, 2024 15:03
@susnux susnux merged commit a54e69c into master May 6, 2024
104 checks passed
@susnux susnux deleted the fix/reduce-http-noise branch May 6, 2024 15:07
This was referenced May 6, 2024
Merged
Merged
@joshtrichards joshtrichards mentioned this pull request May 6, 2024
Closed
@susnux susnux mentioned this pull request Jun 10, 2024
Merged
4 tasks
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fenn-CS Fenn-CS Fenn-CS approved these changes

@szaimen szaimen szaimen approved these changes

@emoral435 emoral435 emoral435 approved these changes

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-frontend

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

[Bug]: Can't enable or disable apps after upgrade to v28.0.4
4 participants
@susnux @Fenn-CS @szaimen @emoral435