perf(templates): Emit RegisterTemplateCreatorEvent to register template creators more lazy #44952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliushaertl
force-pushed
the
perf/44951/template-creator
branch
from
7532009
to
bed9fad
Compare
24 tasks
…te creators more lazy Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
force-pushed
the
perf/44951/template-creator
branch
from
bed9fad
to
f9e235f
Compare
blizzz
approved these changes
Apr 22, 2024
This was referenced Apr 22, 2024
elzody
approved these changes
Apr 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for lazy registration of template creators (which are objects that define how a new file can be created for apps like text/collabora/onlyoffice)
While generally I'd prefer to move this to the register method instead of using an event this requires some API redesign so this event is a quick solution.
Contributes to #44951