perf(ILockManager): Allow registering a lock provider lazy #44953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 22, 2024
juliusknorr
force-pushed
the
perf/44951/lock-provider
branch
from
4ec8584
to
8079df9
Compare
juliusknorr
requested review from
grnd-alt,
max-nextcloud,
a team,
ArtificialOwl,
nfebe and
yemkareems
and removed request for
a team
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
perf/44951/lock-provider
branch
from
8079df9
to
ff3fc85
Compare
nfebe
approved these changes
Apr 30, 2024
hweihwang
approved these changes
May 13, 2024
| @@ -42,9 +42,17 @@ interface ILockManager extends ILockProvider { | |||
| /** | |||
| * @throws PreConditionNotMetException if there is already a lock provider registered | |||
| * @since 24.0.0 | |||
| * @deprecated 30.0.0 Use registerLazyLockProvider | |||
There was a problem hiding this comment.
juliusknorr
added a commit
to nextcloud/documentation
that referenced
this pull request
Jul 19, 2024
nextcloud/server#44953 Signed-off-by: Julius Härtl <jus@bitgrid.net>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to register the lock provider without directly initializing required dependencies through DI we need to register it lazy.
As the LockManager is only handling registration/delegation of method calls it doesn't come with its own dependencies and therefore is enough to handle this. We could also move this to a dedicated registerLockProvider method but as of now there is just one use case with the files_lock app and this seems too little to justify for a explicit registration method.
Contributes to #44951
Required for nextcloud/files_lock#297