Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update last_login timestamp for token based-logins #45020

Merged

Conversation

Noodlesalat
Copy link
Member

@Noodlesalat Noodlesalat commented Apr 24, 2024

Summary

Currently, the last login timestamp of a user is only updated when he logs in with his password. Since token-based logins do not update the timestamp, it may appear as if the user is inactive although he is regularly logged in with token-based clients (desktop client, mobile app, ...).

For this reason, the last_login timestamp should be updated for each individual login.

Checklist

@Noodlesalat Noodlesalat force-pushed the fix-lastlogin-update-token-login branch 2 times, most recently from 59c4b24 to b84a5dd Compare April 24, 2024 21:09
@solracsf solracsf added this to the Nextcloud 30 milestone Jun 18, 2024
This was referenced Jul 30, 2024
This was referenced Aug 5, 2024
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
@skjnldsv skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 14, 2024
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, last login is also debounced for 60 seconds so this should be fine performance wise.

fixes nextcloud#31075 and maybe nextcloud#32953

Signed-off-by: Fabian Dreßler <nudelsalat@clouz.de>
@skjnldsv skjnldsv merged commit eb374a7 into nextcloud:master Sep 17, 2024
161 of 164 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants