fix(argon2): respect max value for hashingThreads #45027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Remi Collet <remi@php.net>
solracsf
approved these changes
Apr 25, 2024
solracsf
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (\defined('PASSWORD_ARGON2_PROVIDER')) { | ||
| // password_hash fails, when the minimum values are undershot or maximum overshot | ||
| // In this case, apply minimum/maximum. | ||
| if (PASSWORD_ARGON2_PROVIDER === 'sodium') { |
Check failure
Code scanning / Psalm
TypeDoesNotContainType Error
There was a problem hiding this comment.
obviously a false positive
$ php -r 'var_dump(PASSWORD_ARGON2_PROVIDER);'
string(6) "sodium"
Merged
skjnldsv
added
2. developing
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When argon2 password hashing is provided bu sodium extension, threads is not supported, so value > 1 raise an exception
See https://github.com/php/php-src/blob/PHP-8.1.28/ext/sodium/sodium_pwhash.c#L65
Threads are only supported by standard extension (libargon2) and soon by openssl extension (with OpenSSL 3.2 and PHP 8.4)
Checklist