Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces "Time:" with "Date and time:" in calendar e-mail notification #45032

Conversation

Jerome-Herbinet
Copy link
Member

@Jerome-Herbinet Jerome-Herbinet commented Apr 25, 2024

This PR replaces "Time:" with "Date and time:" in calendar e-mail notification.

Tests from reviewers needed.

It's more relevant because, this includes a date and a time on the same text line in the e-mail event invitation.

Checklist

@Jerome-Herbinet Jerome-Herbinet changed the title Replaces "Time:" with "Date and time:" in e-mail notification Replaces "Time:" with "Date and time:" in calendar e-mail notification Apr 25, 2024
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me wording-wise to be more specific!

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Suggested commit title fix(dav): Replaces "Time:" with "Date and time:" in calendar invite email

@Jerome-Herbinet Jerome-Herbinet force-pushed the Jerome-Herbinet-date-and-time-wording-in-email-notifcation branch from 2e2c1b4 to c8fa7e7 Compare May 7, 2024 12:18
@joshtrichards joshtrichards force-pushed the Jerome-Herbinet-date-and-time-wording-in-email-notifcation branch from c8fa7e7 to 14fa9b9 Compare May 10, 2024 14:08
…mail

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
@Jerome-Herbinet Jerome-Herbinet force-pushed the Jerome-Herbinet-date-and-time-wording-in-email-notifcation branch from 14fa9b9 to 1ffdebd Compare May 23, 2024 13:37
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 23, 2024
@ChristophWurst ChristophWurst merged commit b72e4e8 into master May 23, 2024
156 checks passed
@ChristophWurst ChristophWurst deleted the Jerome-Herbinet-date-and-time-wording-in-email-notifcation branch May 23, 2024 14:34
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: activity and notification feature: caldav Related to CalDAV internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants