Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(usergroups): clear cached user groups on pre hooks #45036

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iLinaza
Copy link

@iLinaza iLinaza commented Apr 25, 2024

Summary

Groups Manager stores the cache of which groups the users belong to. This can be inconsistent at certain times as it is cleared late (in post hooks).

When a user is added to a group the following steps are taken (in OC\Group\Group, addUser method):

  1. The preAddUser hook is called.
  2. The backend is called to actually add the user to the group.
  3. The UserAddedEvent event is dispatched.
  4. The postAddUser hook is called.

The cache is cleared in the postAddUser hook, in the Manager. When someone performs operations on the UserAddedEvent event and is checking which groups the user belongs to, the Manager may be returning invalid data since the cache may be in an inconsistent state. The user has already been added to the group but the cache is cleared later, in the postAddUser hook, and the manager returns outdated group list.

Before the cache is cleared, the file_sharing app is doing the sharing of folders to the newly added user (in OCA\Files_Sharing\Listener\UserAddedToGroupListener), in the UserAddedEvent event. But, at this point, when the user is created by SAML, the cache is in a incosistent state because it has not been cleared yet and is being retrieved from cache. It will be cleared later, in the postAddUser hook.

Checklist

Signed-off-by: iLinaza <i.linaza@gmail.com>
@solracsf solracsf added this to the Nextcloud 30 milestone Apr 26, 2024
@solracsf solracsf requested review from icewind1991 and blizzz April 26, 2024 06:48
@solracsf solracsf changed the title fix: #45034 clear cached user groups on pre hooks fix(usergroups): clear cached user groups on pre hooks Apr 26, 2024
@blizzz
Copy link
Member

blizzz commented Apr 30, 2024

I am not sure which side effects this would have. Scary change ;) Would it not be better to emit additional Events in user_saml?

@iLinaza
Copy link
Author

iLinaza commented May 2, 2024

In my case, am clearing the cache in the pre event, using reflectivity from a custom App, and it is working fine, but I don't know if it can have consequences in other Apps that we don't use.

Clearing the cache of groups to which users belong must be the task immediately before or after the user is added to a group. I understand that, if we could ensure that, doing it in the pre-hook is the last thing to be executed it should be working fine, but I don't think priority can be added to hook subscriptions, as it is possible with Events.

Otherwise, as you say, a new event or Hook could be added, but in the long run the same problem (execution order) could occur if more applications use that event? Alternatively, we could use the already existing event, UserAddedEvent, and add the subscription to clear the cache with the highest possible priority value, instead of using the post- hooks.

This was referenced Jul 30, 2024
@Altahrim Altahrim mentioned this pull request Aug 5, 2024
@skjnldsv skjnldsv added 2. developing Work in progress stale Ticket or PR with no recent activity and removed 3. to review Waiting for reviews labels Aug 6, 2024
@Altahrim Altahrim mentioned this pull request Aug 7, 2024
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
@skjnldsv skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 14, 2024
@hrenard
Copy link
Contributor

hrenard commented Dec 12, 2024

@blizzz, would something like hrenard@0aefd68 be safer ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress bug feature: users and groups stale Ticket or PR with no recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Shared folders don’t show up for new users created by SAML
6 participants