Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Education "bundle" #45091

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

Jerome-Herbinet
Copy link
Member

@Jerome-Herbinet Jerome-Herbinet commented Apr 29, 2024

Because all other application groupings use the word “bundle”.

Checklist

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me for consistency, but just checking in with @jospoortvliet in case this is used in language elsewhere.

@jospoortvliet
Copy link
Member

We no longer advertise the education edition as such, so I think it's fine to rename. Then, if/when we talk about this in public again, we also use the new naming scheme. Thanks!

@Jerome-Herbinet Jerome-Herbinet force-pushed the Jerome-Herbinet-education-bundle branch from 6e7e928 to 522e6d2 Compare May 24, 2024 11:20
@jancborchardt
Copy link
Member

@jospoortvliet could you approve then as well? :)

@solracsf solracsf added this to the Nextcloud 30 milestone Jun 18, 2024
This was referenced Jul 30, 2024
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@jancborchardt jancborchardt force-pushed the Jerome-Herbinet-education-bundle branch from 1bab539 to c221090 Compare August 6, 2024 09:14
@AndyScherzinger AndyScherzinger merged commit 7a7f259 into master Aug 6, 2024
167 of 169 checks passed
@AndyScherzinger AndyScherzinger deleted the Jerome-Herbinet-education-bundle branch August 6, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants