Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dav): Don't log access control as error #45120

Merged
merged 1 commit into from
Jun 10, 2024
Merged

fix(dav): Don't log access control as error #45120

merged 1 commit into from
Jun 10, 2024

Conversation

nickvergessen
Copy link
Member

  • Resolves:

Expected

  • Create an access control rule blocking an item inside a folder
  • Access the folder
  • All good

Actual

  • An error in the log file for each time the directory is listed

Checklist

@nickvergessen
fix(dav): Don't log access control as error
89bce5c 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 30 milestone Apr 30, 2024
@nickvergessen nickvergessen requested a review from a team April 30, 2024 11:49
@nickvergessen nickvergessen self-assigned this Apr 30, 2024
@nickvergessen nickvergessen requested review from ArtificialOwl, Fenn-CS and yemkareems and removed request for a team April 30, 2024 11:49
@susnux susnux merged commit 9d0200c into master Jun 10, 2024
157 checks passed
@susnux susnux deleted the bugfix/noid/sensitive-dav-forbidden-logging branch June 10, 2024 09:56
@nickvergessen
Copy link
Member Author

/backport to stable29

@nickvergessen
Copy link
Member Author

/backport to stable28

@nickvergessen
Copy link
Member Author

/backport to stable27

@backportbot backportbot bot mentioned this pull request Jun 10, 2024
Merged
This was referenced Jun 10, 2024
Merged
Merged
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@kesselb kesselb kesselb approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS Fenn-CS was automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems was automatically assigned from nextcloud/server-backend

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews bug feature: dav
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @susnux @kesselb