Refactors theming app - part 2 #45137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsamapoor
force-pushed
the
refactor_theming_app_part2
branch
from
a8d25b3
to
89e69a6
Compare
fsamapoor
requested review from
a team,
ArtificialOwl,
Fenn-CS and
yemkareems
and removed request for
a team
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
… property promotion feature. Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
fsamapoor
force-pushed
the
refactor_theming_app_part2
branch
from
89e69a6
to
11f9ce6
Compare
Merged
skjnldsv
added
2. developing
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following previous PRs taking advantage of PHP8's constructor property promotion, I have also made the required adjustments to the classes in the
themingapp.I decided to split the changes into multiple PRs to make reviewing the changes easier.
The improvements in this PR include:
Checklist