Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors theming app - part 3 #45145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fsamapoor
Copy link
Member

Summary

Following previous PRs taking advantage of PHP8's constructor property promotion, I have also made the required adjustments to the classes in the theming app.

I decided to split the changes into multiple PRs to make reviewing the changes easier.

The improvements in this PR include:

  • Using PHP8's constructor property promotion
  • Adding return types
  • Removing redundant docblocks

Checklist

… property promotion feature.

Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
@fsamapoor fsamapoor added 3. to review Waiting for reviews technical debt labels May 2, 2024
@fsamapoor fsamapoor requested review from a team, ArtificialOwl, icewind1991 and yemkareems and removed request for a team May 2, 2024 07:46
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@solracsf solracsf added this to the Nextcloud 30 milestone Jun 18, 2024
This was referenced Jul 30, 2024
This was referenced Aug 5, 2024
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
@skjnldsv skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants