-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide 'updater.server.url' As It May Contain Enterprise Key #45236
Conversation
/backport to stable29 |
/backport to stable28 |
/backport to stable27 |
Beat me to it. I saw that. I guess it's appropriate it was you that submitted it. :) Can you fix the commit message? Needs to be conventional commit format. e.g. EDIT: I fixed the other issue impacting the cs-fixer test. Just a spaces versus tab matter. |
@joshtrichards sorry I was in vacation the last days and renaming old commits seems to be a pain :) But there you go! |
Add "updater.server.url" to the privacy redacted values, as it may contain the enterprise key. Signed-off-by: derschiw <37687705+derschiw@users.noreply.github.com>
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
/backport to stable29 |
/backport to stable28 |
/backport to stable27 |
The backport to # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b backport/45236/stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 28807b2a
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45236/stable27 Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/45236/stable27."} Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/45236/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 28807b2a
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45236/stable28 Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/45236/stable28."} Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/45236/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 28807b2a
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45236/stable29 Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/45236/stable29."} Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
LOL. What's up with the bot? It created valid backports already. Those backports are fine. Not sure why it tried to do it a second time for each on its own. |
well I summoned it again.. didnt seethe comments as they were folded away |
Oh. Oops. Sorry, bot. I blamed you for no reason. It was us. My mistake. |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Summary
Add "updater.server.url" to the privacy redacted values, as it may contain the enterprise key.
Checklist