feat: add ability to sort by last login #45249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Pytal
reviewed
May 10, 2024
kesselb
added
2. developing
kesselb
reviewed
May 11, 2024
Pytal
reviewed
Jun 6, 2024
4 tasks
yemkareems
force-pushed
the
feature/add-ability-to-sort-by-last-login
branch
from
fdba92d
to
0de617e
Compare
yemkareems
added
3. to review
come-nc
reviewed
Jul 1, 2024
come-nc
reviewed
Jul 2, 2024
come-nc
requested changes
Jul 4, 2024
come-nc
requested changes
Jul 4, 2024
…rder is lastLogin DESC Signed-off-by: yemkareems <yemkareems@gmail.com>
Signed-off-by: yemkareems <yemkareems@gmail.com>
… uid asc. enable email search by changing query Signed-off-by: yemkareems <yemkareems@gmail.com>
fix: added a new endpoint users/recent and getting users based on last login info in the same. Reverted old code that was breaking LDAP Signed-off-by: yemkareems <yemkareems@gmail.com>
Signed-off-by: yemkareems <yemkareems@gmail.com>
…s sort and order are not required here Signed-off-by: yemkareems <yemkareems@gmail.com>
…s sort and order are not required here Signed-off-by: yemkareems <yemkareems@gmail.com>
Signed-off-by: yemkareems <yemkareems@gmail.com>
Signed-off-by: yemkareems <yemkareems@gmail.com>
…by lastLogin Signed-off-by: yemkareems <yemkareems@gmail.com>
Signed-off-by: yemkareems <yemkareems@gmail.com>
…as per getDisplayNames function. limit and offset added to query. default limit set to 25. Signed-off-by: yemkareems <yemkareems@gmail.com>
…hed or if limit is given limit number of users are fetched Signed-off-by: yemkareems <yemkareems@gmail.com>
…. removed getUsersSortedByLastLogin from Manager and instead used the config in controller Signed-off-by: yemkareems <yemkareems@gmail.com>
… login Signed-off-by: yemkareems <yemkareems@gmail.com>
… available Signed-off-by: yemkareems <yemkareems@gmail.com>
Signed-off-by: yemkareems <yemkareems@gmail.com>
Signed-off-by: yemkareems <yemkareems@gmail.com>
Signed-off-by: yemkareems <yemkareems@gmail.com>
Signed-off-by: yemkareems <yemkareems@gmail.com>
Signed-off-by: yemkareems <yemkareems@gmail.com>
…r/Manager Signed-off-by: yemkareems <yemkareems@gmail.com>
yemkareems
force-pushed
the
feature/add-ability-to-sort-by-last-login
branch
from
dd27c57
to
4eba967
Compare
Signed-off-by: provokateurin <kate@provokateurin.de>
artonge
approved these changes
Jul 8, 2024
| * @return list<string> list of user IDs | ||
| * @since 30.0.0 | ||
| */ | ||
| public function getLastLoggedInUsers(?int $limit = null, int $offset = 0, string $search = ''): array; |
There was a problem hiding this comment.
nickvergessen
added
the
pending documentation
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist