Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Align mariadb versions with list of supported versions #45255

Merged
merged 1 commit into from
May 10, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented May 10, 2024

Summary

We currently support 10.3, 10.5, 10.6 (old LTS) and 10.11 (current LTS) so we can drop 10.4 from CI and save a bit of CI time.

Checklist

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also in .github?

@susnux
Copy link
Contributor Author

susnux commented May 10, 2024

Also in .github?

The templates only check for LTS version 10.6 and 10.11 (and in few weeks probably 11.4)

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux enabled auto-merge May 10, 2024 21:38
@susnux susnux merged commit 18a8120 into master May 10, 2024
158 checks passed
@susnux susnux deleted the fix/ci-mariadb branch May 10, 2024 21:46
@solracsf
Copy link
Member

solracsf commented May 14, 2024

Why have dropped 10.4 and not 10.3 (which is EOL) ?
https://endoflife.date/mariadb

@nickvergessen
Copy link
Member

Sounds like a mistake. I think someone mentioned .3 to be an LTS, but .4 actually is the LTS

@susnux
Copy link
Contributor Author

susnux commented May 16, 2024

No 10.3 is supported because of Ubuntu 20.04 shipping it and we support Ubuntu 20.04

10.4 was dropped on purpose as it is only a short term stable and will be eol when Nextcloud 30 is released

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants