Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temporary variable for border radius #45295

Merged
merged 2 commits into from
May 29, 2024

Conversation

marcoambrosini
Copy link
Member

No description provided.

@marcoambrosini marcoambrosini self-assigned this May 15, 2024
@marcoambrosini marcoambrosini added this to the Nextcloud 30 milestone May 15, 2024
@marcoambrosini marcoambrosini force-pushed the add-temporary-border-radius-variable branch from 5db12d2 to 3dc641f Compare May 16, 2024 08:21
@marcoambrosini marcoambrosini added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 16, 2024
@marcoambrosini marcoambrosini requested review from a team, artonge and come-nc May 16, 2024 08:22
@szaimen
Copy link
Contributor

szaimen commented May 16, 2024

It is missing in the theming app...

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix it in the theming app yep 👍
Otherwise, good from me

@marcoambrosini marcoambrosini force-pushed the add-temporary-border-radius-variable branch 2 times, most recently from b27e20d to 2169ebd Compare May 16, 2024 14:47
@skjnldsv
Copy link
Member

Failure related

@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels May 16, 2024
susnux
susnux previously requested changes May 16, 2024
apps/theming/css/default.css Outdated Show resolved Hide resolved
Signed-off-by: Marco Ambrosini <marcoambrosini@proton.me>
@susnux susnux force-pushed the add-temporary-border-radius-variable branch from c7f239e to 5b68390 Compare May 27, 2024 21:57
@marcoambrosini
Copy link
Member Author

Damn whitespace 🤦 😅

Screenshot 2024-05-29 at 09 13 14

Co-authored-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Marco <marcoambrosini@proton.me>
@marcoambrosini marcoambrosini force-pushed the add-temporary-border-radius-variable branch from 5b68390 to 405fd9a Compare May 29, 2024 07:19
@marcoambrosini marcoambrosini merged commit b7b2966 into master May 29, 2024
155 checks passed
@marcoambrosini marcoambrosini deleted the add-temporary-border-radius-variable branch May 29, 2024 07:52
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants