Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(systemtags): Add index for systemtags_object_mappings.objectid #45306

Merged

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented May 14, 2024

Summary

Adds an index for queries that select by objectid only.

Checklist

@ChristophWurst ChristophWurst added this to the Nextcloud 30 milestone May 14, 2024
@ChristophWurst ChristophWurst requested a review from a team May 14, 2024 10:17
@ChristophWurst ChristophWurst self-assigned this May 14, 2024
@ChristophWurst ChristophWurst requested review from icewind1991, yemkareems, sorbaugh and artonge and removed request for a team and sorbaugh May 14, 2024 10:17
@ChristophWurst
Copy link
Member Author

/backport to stable29

@ChristophWurst
Copy link
Member Author

/backport to stable28

@ChristophWurst
Copy link
Member Author

/backport to stable27

Copy link
Member

@solracsf solracsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but backport to stable27 will probably fail 🙈

@ChristophWurst
Copy link
Member Author

I declare the Cypress failure unrelated

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 4, 2024
@icewind1991 icewind1991 force-pushed the perf/systemtags-object-mapping-objectid-index branch from 40c4750 to 215640d Compare June 21, 2024 08:46
@blizzz blizzz mentioned this pull request Jul 30, 2024
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the perf/systemtags-object-mapping-objectid-index branch from 215640d to 9f23b43 Compare July 30, 2024 11:13
@ChristophWurst ChristophWurst merged commit f4eff74 into master Jul 31, 2024
170 checks passed
@ChristophWurst ChristophWurst deleted the perf/systemtags-object-mapping-objectid-index branch July 31, 2024 09:08
Copy link

backportbot bot commented Jul 31, 2024

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b backport/45306/stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 9f23b43e

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45306/stable27

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@blizzz blizzz mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish backport-request bug performance 🚀
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Missing index for systemtag_object_mapping.objectid
3 participants