Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(files): refresh preview on etag change #45417

Merged
merged 1 commit into from
May 23, 2024
Merged

feat(files): refresh preview on etag change #45417

merged 1 commit into from
May 23, 2024

Conversation

skjnldsv
Copy link
Member

Fix #44630

@skjnldsv skjnldsv added this to the Nextcloud 30 milestone May 21, 2024
@skjnldsv skjnldsv requested review from artonge and a team May 21, 2024 09:52
@skjnldsv skjnldsv self-assigned this May 21, 2024
@skjnldsv skjnldsv requested review from nfebe and szaimen and removed request for a team May 21, 2024 09:52
@skjnldsv
Copy link
Member Author

/backport to stable29

@skjnldsv
Copy link
Member Author

/backport to stable28

szaimen
szaimen approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. :)

However the sidebar still seems to have the old picture:
image

@skjnldsv skjnldsv requested a review from susnux May 21, 2024 15:51
susnux
susnux reviewed May 21, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works but also needs to be fixed on apps/files/src/views/Sidebar.vue::getPreviewIfAny

@skjnldsv
Copy link
Member Author

Works but also needs to be fixed on apps/files/src/views/Sidebar.vue::getPreviewIfAny

Sure 😅

@skjnldsv skjnldsv force-pushed the fix/preview-clear-files-etag branch 4 times, most recently from 16170be to ed8c1bd Compare May 22, 2024 06:22
@skjnldsv skjnldsv requested a review from susnux May 22, 2024 06:22
@skjnldsv skjnldsv force-pushed the fix/preview-clear-files-etag branch from ed8c1bd to 56d208c Compare May 22, 2024 06:23
szaimen
szaimen approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. However the conflict picker also has the problem:
image

@skjnldsv skjnldsv mentioned this pull request May 22, 2024
Merged
@skjnldsv
Copy link
Member Author

the conflict picker also has the problem

nextcloud-libraries/nextcloud-upload#1214

@skjnldsv
Copy link
Member Author

/compile rebase-amend /

@skjnldsv skjnldsv enabled auto-merge May 23, 2024 11:52
@skjnldsv @nextcloud-command
feat(files): refresh preview on etag change
3ca3c65 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 23, 2024
@skjnldsv skjnldsv merged commit c5dc1b5 into master May 23, 2024
104 checks passed
@skjnldsv skjnldsv deleted the fix/preview-clear-files-etag branch May 23, 2024 12:26
susnux
susnux reviewed May 23, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux left review comments

@szaimen szaimen szaimen approved these changes

@artonge artonge artonge approved these changes

@nfebe nfebe Awaiting requested review from nfebe nfebe was automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish backport-request enhancement feature: files feature: previews and thumbnails technical debt
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

[Bug]: Thumbnail doesn't update when source image is changed
4 participants
@skjnldsv @susnux @artonge @szaimen