Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): unsupported browser redirect url #45494

Merged
merged 2 commits into from
Jun 2, 2024
Merged

Conversation

skjnldsv
Copy link
Member

Fix #43142

To easily try this, just use a php webserver on a freshly cloned server repo

@skjnldsv skjnldsv added bug 3. to review Waiting for reviews labels May 24, 2024
@skjnldsv skjnldsv added this to the Nextcloud 30 milestone May 24, 2024
@skjnldsv skjnldsv self-assigned this May 24, 2024
@skjnldsv skjnldsv requested review from a team, Pytal, szaimen and sorbaugh and removed request for a team May 24, 2024 09:11
@szaimen
Copy link
Contributor

szaimen commented May 24, 2024

Hey @skjnldsv I'd like to test this but don't know how to get an unsupported browser onto my PC. Do you have any idea which browser I could try?

@skjnldsv
Copy link
Member Author

but don't know how to get an unsupported browser onto my PC.

On the dev tools you can change the user agent into the "other network conditions". You can select and edit a chrome version for example
image

@skjnldsv skjnldsv requested a review from artonge May 24, 2024 11:32
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works

Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to work when there is a webroot e.g. "/nextcloud" 🤔

@skjnldsv
Copy link
Member Author

image
Fixed @Pytal

@skjnldsv skjnldsv requested a review from Pytal May 30, 2024 13:46
Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a quickfix, ReferenceError: getRootUrl is not defined 🙈

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Copy link
Member Author

skjnldsv commented Jun 1, 2024

/compile amend-rebase /

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 1, 2024
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
@skjnldsv skjnldsv merged commit d045482 into master Jun 2, 2024
151 of 155 checks passed
@skjnldsv skjnldsv deleted the fix/unsupported-redirect branch June 2, 2024 10:17
@skjnldsv
Copy link
Member Author

skjnldsv commented Jun 2, 2024

/backport to stable29

@skjnldsv
Copy link
Member Author

skjnldsv commented Jun 2, 2024

/backport to stable28

@skjnldsv
Copy link
Member Author

skjnldsv commented Jun 2, 2024

/backport to stable27

@skjnldsv
Copy link
Member Author

skjnldsv commented Jun 7, 2024

/backport to stable29

Copy link

backportbot bot commented Jun 7, 2024

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/45494/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick fc3ee655 1a8f0c92

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45494/stable29

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/45494/stable29."}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish backport-request bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Wrong redirection with the button Continue with this unsupported browser
3 participants