-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): unsupported browser redirect url #45494
Conversation
Hey @skjnldsv I'd like to test this but don't know how to get an unsupported browser onto my PC. Do you have any idea which browser I could try? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't seem to work when there is a webroot e.g. "/nextcloud" 🤔
f912966
to
6201ada
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a quickfix, ReferenceError: getRootUrl is not defined
🙈
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
6cc228d
to
18539bb
Compare
/compile amend-rebase / |
18539bb
to
6b8c3af
Compare
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
6b8c3af
to
1a8f0c9
Compare
/backport to stable29 |
/backport to stable28 |
/backport to stable27 |
/backport to stable29 |
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/45494/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick fc3ee655 1a8f0c92
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45494/stable29 Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/45494/stable29."} Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Fix #43142
To easily try this, just use a php webserver on a freshly cloned server repo