Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OC namespace for core ReponseDefinitions instead of OCA #45509

Merged

Conversation

JulienFS
Copy link

@JulienFS JulienFS commented May 26, 2024

Summary

It looks like #36666 and #39331 lead to having a core file in the OCA namespace. To my understanding, OCA is for apps, while OC\Core is for core.

TODO

  • check that there's no magic involved with namespaces regarding OpenAPI and that these changes are an applicative NOOP

Checklist

Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@provokateurin provokateurin added this to the Nextcloud 30 milestone May 26, 2024
@provokateurin
Copy link
Member

/backport to stable29

@provokateurin
Copy link
Member

/backport to stable28

@JulienFS JulienFS force-pushed the fix/openapi/response-namespace branch from 352a2a1 to f1952e1 Compare May 26, 2024 09:38
@provokateurin
Copy link
Member

Your commit should probably start with fix(core): (and you can just squash them).

@provokateurin
Copy link
Member

@JulienFS please fix the CI (code checkers and lint php-cs)

@JulienFS JulienFS force-pushed the fix/openapi/response-namespace branch from 5ba2d6d to 7fe4569 Compare May 27, 2024 07:53
@JulienFS
Copy link
Author

Performance and cypress don't seem to pass. At first sight I don't know what to do. Should I try to fix them or is it somehow out of my hands ?

@provokateurin
Copy link
Member

No those are flaky sometimes. I just gotta restart cypress until it works (and performance is not required to pass)

@kesselb kesselb force-pushed the fix/openapi/response-namespace branch from 435f778 to 4f5e651 Compare June 6, 2024 10:30
Copy link
Contributor

github-actions bot commented Jun 9, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@provokateurin
Copy link
Member

The CI on this PR seems to be really unlucky 😞

@provokateurin provokateurin force-pushed the fix/openapi/response-namespace branch from 4f5e651 to e3d1d8c Compare June 9, 2024 06:22
Signed-off-by: Julien CHATY-CAPELLE <julien@chaty-capelle.fr>
@provokateurin provokateurin force-pushed the fix/openapi/response-namespace branch from e3d1d8c to 2d84d0f Compare July 15, 2024 09:50
@nickvergessen nickvergessen merged commit fe597d8 into nextcloud:master Jul 15, 2024
159 of 166 checks passed
Copy link

welcome bot commented Jul 15, 2024

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@nickvergessen
Copy link
Member

/backport to stable29

Copy link

backportbot bot commented Jul 15, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/45509/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 2d84d0f5

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45509/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Jul 15, 2024

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/45509/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 2d84d0f5

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45509/stable29

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

1 similar comment
Copy link

backportbot bot commented Jul 15, 2024

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/45509/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 2d84d0f5

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45509/stable29

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants