feat(ldap): sync additional properties to profile and SAB

[st3iny]

• Resolves More LDAP User Profile Attributes #40194
• Continuation of Add additional user profile attributes from LDAP #41793

Summary

This PR merges #41793 and #39592. I added neccessary frontend code so that users can change their date of births and adjust the scope in case they don't want it to be synced to the SAB.

I also removed the anniversary date after having a discussion with our designers. We are required to take the detour via the profile page to allow users to set the scope. Considering the broad spectrum that Nextcloud is used in, it doesn't make sense to have an anniversary date on the profile.

Synced from LDAP to profile:

• Date of birth

Synced from LDAP to SAB (via the profile):

• Biography
• Date of birth

Original code by Jake Nabasny (GitHub: @slapcat). Your contribution is highly valued ❤️

Screenshots

Synced contact in SAB

Date of birth in personal settings

LDAP wizard (advanced tab)

TODO

• Tests (probably)

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[st3iny]

Pending documentation at nextcloud/documentation#11323 (although it has to be adjusted to the removed anniversary field).

[come-nc]

What kind of LDAP attribute was this tested with?
I’m afraid it won’t work with LDAP date format which is quite specific and not supported by PHP out-of-the-box.

[come-nc]

See https://datatracker.ietf.org/doc/html/rfc4517#section-3.3.13

[st3iny]

Côme made a good point. There is no standardized birthdate field on LDAP. However, some implementations use the standardized generalized date format while others user the YYYY-MM-DD format.

So we need a parser for the LDAP format and fallback to the date constructor.

[slapcat]

@come-nc I tested it with an attribute using the same Generalized Time syntax that you linked and it worked fine for both showing the date in the frontend and generating it on contact cards for the cardDAV server. Here is the full attribute type I use:

olcAttributeTypes: {0}( 1.3.6.1.4.1.59010.1.1 NAME 'birthDate' DESC 'Birthday'
  EQUALITY generalizedTimeMatch ORDERING generalizedTimeOrderingMatch SYNTAX 1
 .3.6.1.4.1.1466.115.121.1.24 SINGLE-VALUE )

[come-nc]

@come-nc I tested it with an attribute using the same Generalized Time syntax that you linked and it worked fine for both showing the date in the frontend and generating it on contact cards for the cardDAV server. Here is the full attribute type I use:

olcAttributeTypes: {0}( 1.3.6.1.4.1.59010.1.1 NAME 'birthDate' DESC 'Birthday'
  EQUALITY generalizedTimeMatch ORDERING generalizedTimeOrderingMatch SYNTAX 1
 .3.6.1.4.1.1466.115.121.1.24 SINGLE-VALUE )

Using the two examples from the RFC the second one crashes DateTime constructor:
https://3v4l.org/uSuTs

Try setting your attribute to "199412160532-0500" which is a valid value from the RFC.

[st3iny]

I added a rudimentary parser, that just uses the first 8 characters from the LDAP generalized syntax and tries to parse YYYYMMDD or YYYY-MM-DD otherwise. Is that sufficient?

I also tested it with a real LDAP generalized time attribute on my local dev instance. Of course, I also added some unit test for the parser method ...

[ChristophWurst]

Looks good

some bundle updates are suspicious. e.g. dist/weather_status-weather-status.js changed

[szaimen]

🎉🎉🎉🎉🎉

[nickvergessen]

@st3iny Please document in Please document in https://docs.nextcloud.com/server/latest/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_30.html#id1

[aurisnoctis]

Will this change allow people to add their birthday to their profile even if the nextcloud server uses not LDAP but the default database?

[st3iny]

@aurisnoctis Yes, it does work without LDAP.