chore: update .jshintrc #45521
Merged
chore: update .jshintrc #45521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - `esversion: 11` We use bundlers so let's use a modern version of js - `maxlen: 120` This should be enforced by linters if at all (the rule is deprected by jshintrc anyway: https://jshint.com/docs/options/#maxlen) - `asi: true` Suppress warnings about missing semicolons (it's 2024 after all) Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
requested review from
szaimen,
sorbaugh and
ChristophWurst
and removed request for
a team and
sorbaugh
AndyScherzinger
approved these changes
May 27, 2024
szaimen
approved these changes
May 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Be able to enable the plugin in PHPStorm again without seeing 100s of irrelevant errors ...
Changes:
esversion: 11We use bundlers so let's use a modern version of jsmaxlen: 120This should be enforced by linters if at all (the rule is deprected by jshintrc anyway: https://jshint.com/docs/options/#maxlen)asi: trueSuppress warnings about missing semicolons (it's 2024 after all)Checklist