Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement action sub-menus in the multiple files actions bar #45525

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

StCyr
Copy link
Contributor

@StCyr StCyr commented May 27, 2024

Summary

Implements submenus in multiple file actions bar

TODO

  • Only show toplevel actions in bar
  • open menu when clicking on a menu action

Checklist

Signed-off-by: root <root@debian-BULLSEYE-live-builder-AMD64>
@StCyr StCyr requested a review from skjnldsv as a code owner May 27, 2024 10:51
@StCyr StCyr self-assigned this May 27, 2024
Signed-off-by: Cyrille Bollu <cyrille@debian-BULLSEYE-live-builder-AMD64>
@StCyr StCyr changed the title Start to implement action sub-menus in the multiple files actions bar Implement action sub-menus in the multiple files actions bar May 31, 2024
@StCyr
Copy link
Contributor Author

StCyr commented May 31, 2024

It seems to functionally work @skjnldsv. Could you have a look?

For some reason the menu actions don't come before non-menu actions. But, this apart, it seems to work as I want.

@skjnldsv
Copy link
Member

Took me a while, I was like: but didn't we added this a few months ago?? 🙈
I see we didn't implemented this in the multiple actions indeed 🙈

I'll have a look next week

@skjnldsv skjnldsv added enhancement 3. to review Waiting for reviews labels May 31, 2024
@StCyr
Copy link
Contributor Author

StCyr commented Jun 2, 2024

I'm a bit annoyed that I can't put the menu actions before the non-menu actions, and that I don't understand how to use the defaultIcon property of the NcActions though

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@skjnldsv
Copy link
Member

sorry @StCyr I'm a bit swamped, I will have to postpone a deeper review until I have a bit more time 😓

@solracsf solracsf added this to the Nextcloud 30 milestone Jun 18, 2024
This was referenced Jul 30, 2024
@Altahrim Altahrim mentioned this pull request Aug 5, 2024
@skjnldsv skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle the fileAction parent property in the multiple files action bar too
3 participants