-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Improved Recurrence Invitations Messages #45547
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Psalm found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
TODO: unit tests |
7ce69d0
to
27b9da6
Compare
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general there are a lot of ternary operators. I'm not a big fan because they sacrifice readability for brevity.
I tagged the ones that are a bit problematic from my point of view. I'd also prefer some of the others to be refactored to regular if statements but have no hard opinions.
E.g. there are a lot of return cond ? a : b
constructs.
It would also be nice to have some exemplary screenshots of the new messages or concrete steps for testing.
For testing just create a new calendar event with at least one attendee that has a valid email address. Here are some screenshots of the new messages... Singleton Partial Day Event Singleton Complete Day Event Recurring Daily Event Recurring Weekly Event Recurring Bi-Weekly Event Recurring Month Event with Absolute Date Recurring Monthly Event with Relative Date |
7940339
to
fb4cf4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Extensive unit tests are great.
fb4cf4a
to
f60780e
Compare
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
f60780e
to
43ee948
Compare
Summary
Improved Recurrence Invitations Messages