Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid duplicate tag inserts by checking if the mapping exists already in db #45580

Merged
merged 3 commits into from
Jun 20, 2024
Merged

fix: avoid duplicate tag inserts by checking if the mapping exists already in db #45580

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8782b87
fix: do a select in systemtag_object_mapping to see if tag exists alr…
yemkareems May 30, 2024
d0883b5
fix: filtering tags based on existing tags and doing a transaction ar…
yemkareems May 30, 2024
87cd784
fix: removed unused variable and check if tag ids are empty before st…
yemkareems Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions lib/private/SystemTag/SystemTagObjectMapper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,27 @@ public function assignTags(string $objId, string $objectType, $tagIds): void {
}

$this->assertTagsExist($tagIds);
$this->connection->beginTransaction();

$query = $this->connection->getQueryBuilder();
yemkareems marked this conversation as resolved.
Show resolved Hide resolved
$query->select('systemtagid')
->from(self::RELATION_TABLE)
->where($query->expr()->in('systemtagid', $query->createNamedParameter($tagIds, IQueryBuilder::PARAM_INT_ARRAY)))
->andWhere($query->expr()->eq('objecttype', $query->createNamedParameter($objectType)))
->andWhere($query->expr()->eq('objectid', $query->createNamedParameter($objId)));
$result = $query->executeQuery();
$rows = $result->fetchAll();
$existingTags = [];
foreach ($rows as $row) {
$existingTags[] = $row['systemtagid'];
}
//filter only tags that do not exist in db
$tagIds = array_diff($tagIds, $existingTags);
yemkareems marked this conversation as resolved.
Show resolved Hide resolved
if (empty($tagIds)) {
// no tags to insert so return here
$this->connection->commit();
return;
}

$query = $this->connection->getQueryBuilder();
$query->insert(self::RELATION_TABLE)
Expand All @@ -135,6 +156,7 @@ public function assignTags(string $objId, string $objectType, $tagIds): void {
}
}

$this->connection->commit();
if (empty($tagsAssigned)) {
return;
}
Expand Down
Loading