delete background jobs by id when cleaning up #45582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
requested review from
a team,
nfebe,
yemkareems and
sorbaugh
and removed request for
a team
come-nc
approved these changes
Jun 10, 2024
artonge
approved these changes
Jun 17, 2024
|
/backport to stable29 |
|
/backport to stable28 |
|
/backport to stable27 |
This was referenced Jun 17, 2024
| * @param int $id | ||
| * @since 30.0.0 | ||
| */ | ||
| public function removeById(int $id): void; |
There was a problem hiding this comment.
nickvergessen
added
the
pending documentation
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of deleting by job name and arguments.
This should both improve performance and reduce the risk of deadlocks