Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(files): Adjust some Typescript code in virtual files list #45585

Merged
merged 5 commits into from
May 31, 2024

Commits on May 31, 2024

  1. refactor(files): Correctly cast table ref to fix TypeScript errors

    Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    susnux committed May 31, 2024
    Configuration menu
    Copy the full SHA
    0cb3288 View commit details
    Browse the repository at this point in the history
  2. refactor(files): Fix Typescript issues in filesListWidth mixin

    Use `defineComponent` to properly inherit typings.
    Expect TS errors for the `$resizeOberserver` as we attach it directly on the component instance.
    `filesListWidth` is now a number which defaults to 0,
    making compares like `this.fileListWidth < 768` valid in Typescript.
    
    Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    susnux committed May 31, 2024
    Configuration menu
    Copy the full SHA
    297f052 View commit details
    Browse the repository at this point in the history
  3. refactor(files): Properly add type information to FilesListTableFooter

    - Add correct type for `nodes` prop.
    - Use `defineComponent` to properly infer Typescript information
    - Correct usage of nullish coalescing operator
    
    Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    susnux committed May 31, 2024
    Configuration menu
    Copy the full SHA
    e8adb97 View commit details
    Browse the repository at this point in the history
  4. refactor(files): Make currentView a prop of FilesListTableFooter

    We already have this as a required prop in `FilesListVirtual`,
    so passing it to the footer is straight forward and removed need of computed
    value.
    
    Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    susnux committed May 31, 2024
    Configuration menu
    Copy the full SHA
    ceafe43 View commit details
    Browse the repository at this point in the history
  5. chore: Compile assets

    Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    susnux committed May 31, 2024
    Configuration menu
    Copy the full SHA
    8e296a5 View commit details
    Browse the repository at this point in the history