Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): Only execute default action if there is an action to perform #45586

Merged
merged 2 commits into from
Jun 4, 2024
Merged

fix(files): Only execute default action if there is an action to perform #45586

merged 2 commits into from
Jun 4, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented May 30, 2024

Summary

Some files do not have a default action (can not be viewed and only downloaded). If the openfile query is set on them the handleOpenFile will throw an error.

Checklist

@susnux susnux added this to the Nextcloud 30 milestone May 30, 2024
@susnux susnux requested review from artonge, Fenn-CS and Pytal May 30, 2024 16:46
@susnux susnux requested a review from skjnldsv as a code owner May 30, 2024 16:46
@susnux
Copy link
Contributor Author

susnux commented May 30, 2024

/backport to stable28

@susnux
Copy link
Contributor Author

susnux commented May 30, 2024

/backport to stable29

@susnux
fix(files): Only execute default action if there is an action to perform
d33cfdd 
Some files do not have a default action (can not be viewed and only downloaded).
If the `openfile` query is set on them the `handleOpenFile` will throw an error.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
Copy link
Contributor Author

susnux commented Jun 4, 2024

/compile

@nextcloud-command
chore(assets): Recompile assets
923e1b8 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 4, 2024
@skjnldsv skjnldsv merged commit 7ac1e2f into master Jun 4, 2024
103 checks passed
@skjnldsv skjnldsv deleted the fix/files-default-action branch June 4, 2024 13:41
This was referenced Jun 4, 2024
Merged
Merged
@juliushaertl juliushaertl mentioned this pull request Jul 9, 2024
Open
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
4 participants
@susnux @artonge @skjnldsv @nextcloud-command